Juan Hernandez has posted comments on this change.
Change subject: packaging: Move ROOT.war to the EAR
......................................................................
Patch Set 6: (1 inline comment)
> Also, will it make sense to add a (white) list of files we allow the servlet
> to return? So if by accident there's a way to ask for other files, the
> servlet will return only one of the files in the list?
Doron, do you mean something like this?
<init-param>
<param-name>files</param-name>
<param-value>
/etc/pki/rhevm/ca.pem
/etc/pki/ovirt-engine/ca.pem
/whatever/ca.pem
</param-value>
</init-param>
That is possible and not very complex to implement. If you think it is
important I will add it, but I prefer to do it in another patch, if possible.
....................................................
File backend/manager/modules/pom.xml
Line 27: <module>root</module>
I used "webroot" in a previous version. I don't like very much "root-context",
as it is not more explicit than just "root". Lets see what others think. Alex,
Ofer, Yair, any suggestion?
--
To view, visit http://gerrit.ovirt.org/3782
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d3aa9af7b78546b5449031c8db23ff766b68496
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
