Alissa Bonas has posted comments on this change. Change subject: engine : creating storage connection with empty port, port is set to 0 ......................................................................
Patch Set 3: Additional thing to check: the REST code is supposed to do a validation of parameters, and port is validated for iscsi (look at BackendStorageServerConnectionsResource add method, port is part of validated parameters) - I recommend to check why REST doesn't raise a proper error. Another point - I remember there used to be some code in either REST or UI (sorry, don't remember the details) that used to set the port to 3260 if user didn't pass it. So perhaps if it still exists, it's better to align the behavior (meaning - not pass 3260) -- To view, visit http://gerrit.ovirt.org/24402 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief68a9b65946d88e3eace6f21fc887ea373725b1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Alissa Bonas <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Cheryn Tan <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
