Ravi Nori has posted comments on this change. Change subject: engine : creating storage connection with empty port, port is set to 0 ......................................................................
Patch Set 3: @Alissa RestAPI only validates the presence or absence of parameters. In the case where empty parameter is passed, JAX-B passes a value of 0. So rest api does not raise an error. I don't see any logic in restapi code that validates the values passed.I can add logic to set default port number if that is preferred. Regarding passing default iscsi port, BackendHostResource.iscsiLogin is passing default port number for VdcActionType.ConnectStorageToVds. Changing that command IMO should not be handled in this patch (if we decide to align the behavior). -- To view, visit http://gerrit.ovirt.org/24402 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief68a9b65946d88e3eace6f21fc887ea373725b1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Alissa Bonas <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Cheryn Tan <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
