Arik Hadas has posted comments on this change.

Change subject: webadmin: RunOnceModel empty string validation
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

can this kind of refactoring be done in VmGeneralModel & 
CustomPropertyValidation ?

http://gerrit.ovirt.org/#/c/24437/1/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/RunOnceModel.java
File 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/RunOnceModel.java:

Line 888: oldDomain
can you also make similar change for oldDomain?


-- 
To view, visit http://gerrit.ovirt.org/24437
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I101f3d24a1bf7dd74b73931258e4dee101931618
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to