Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: RunOnceModel empty string validation ......................................................................
webadmin: RunOnceModel empty string validation Replaced the test for domain's emptiness from StringHelper.stringsEquals(selectedDomain, "") to a simpler StringHelper.isNullOrEmpty(selectedDomain). Note that although there is a slight difference in semantics, there is no point in having a null selectedDomain, and it's implicitly assumed to be not-null in other places of the code. Change-Id: I101f3d24a1bf7dd74b73931258e4dee101931618 Signed-off-by: Allon Mureinik <[email protected]> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/RunOnceModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24437 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I101f3d24a1bf7dd74b73931258e4dee101931618 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
