David Caro has posted comments on this change. Change subject: Add generic code to check repoclosure ......................................................................
Patch Set 3: Code-Review-1 (4 comments) http://gerrit.ovirt.org/#/c/24802/3/jobs/packaging/repo_closure_check.sh File jobs/packaging/repo_closure_check.sh: Line 3: LAYOUT Maybe specify a default layout Line 21: [- using simple '[' you must leave a space after the '[' or it will fail. Line 22: ="${ something a little nicer than just 'v' would be nice (val or value), not needed though. Line 78: repofrompath Check the job again, jpackage repos are also needed now for centos -- To view, visit http://gerrit.ovirt.org/24802 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I762abf97c9020301a388f7d83c7d1e41bdf1f062 Gerrit-PatchSet: 3 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Kiril Nesenko <[email protected]> Gerrit-Reviewer: David Caro <[email protected]> Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <[email protected]> Gerrit-Reviewer: Eyal Edri <[email protected]> Gerrit-Reviewer: Ohad Basan <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
