Sandro Bonazzola has posted comments on this change. Change subject: Add generic code to check repoclosure ......................................................................
Patch Set 10: (4 comments) http://gerrit.ovirt.org/#/c/24802/10/jobs/packaging/repo_closure_check.sh File jobs/packaging/repo_closure_check.sh: Line 1: #!/bin/sh Line 2: Line 3: LAYOUT="" FEDORA_MIRROR="http://mirrors.kernel.org/fedora/"; you should use constants for mirrors also for CentOS and JPackage Line 4: BASE_URL="http://resources.ovirt.org"; Line 5: Line 6: die() { Line 7: local m="${1}" Line 86: --repofrompath=check-extras,http://centos.mirror.constant.com/"${DISTRIBUTION_VERSION}"/extras/x86_64/ \ Line 87: --repofrompath=check-epel,http://linux.mirrors.es.net/fedora-epel/"${DISTRIBUTION_VERSION}"/x86_64/ \ Line 88: --repofrompath=check-glusterfs-epel,http://download.gluster.org/pub/gluster/glusterfs/LATEST/EPEL.repo/epel-6/x86_64/ \ Line 89: --repofrompath=check-glusterfs-epel-noarch,http://download.gluster.org/pub/gluster/glusterfs/LATEST/EPEL.repo/epel-6.4/noarch \ Line 90: --repofrompath=check-jpackage-rhel5,ftp://jpackage.hmdc.harvard.edu/JPackage/6.0/redhat-el-5.0/free \ ftp://jpackage.hmdc.harvard.edu/JPackage/6.0/generic/free Line 91: --repofrompath=check-jpackage-generic,ftp://jpackage.hmdc.harvard.edu/JPackage/6.0/generic/free \ Line 92: -l check-updates \ Line 93: -l check-extras \ Line 94: -l check-epel \ Line 104: custom_url="${BASE_URL}/${REPO_NAME}/rpm/${repo}" Line 105: repoclosure \ Line 106: -t \ Line 107: --repofrompath=check-custom,"${custom_url}" \ Line 108: --repofrompath=check-fedora,http://mirrors.kernel.org/fedora/releases/"${DISTRIBUTION_VERSION}"/Everything/x86_64/os/ \ ${FEDORA_MIRROR}/releases/"${DISTRIBUTION_VERSION}"/Everything/x86_64/os/ Line 109: --repofrompath=check-updates,http://mirrors.servercentral.net/fedora/updates/"${DISTRIBUTION_VERSION}"/x86_64/ \ Line 110: --repofrompath=check-updates-testing,http://mirrors.servercentral.net/fedora/updates/testing/"${DISTRIBUTION_VERSION}"/x86_64/ \ Line 111: -l check-fedora \ Line 112: -l check-updates \ Line 105: repoclosure \ Line 106: -t \ Line 107: --repofrompath=check-custom,"${custom_url}" \ Line 108: --repofrompath=check-fedora,http://mirrors.kernel.org/fedora/releases/"${DISTRIBUTION_VERSION}"/Everything/x86_64/os/ \ Line 109: --repofrompath=check-updates,http://mirrors.servercentral.net/fedora/updates/"${DISTRIBUTION_VERSION}"/x86_64/ \ "${FEDORA_MIRROR}"/updates/"${DISTRIBUTION_VERSION}"/x86_64/ Note that you're missing i686 and ppc64 here which should be supported. Line 110: --repofrompath=check-updates-testing,http://mirrors.servercentral.net/fedora/updates/testing/"${DISTRIBUTION_VERSION}"/x86_64/ \ Line 111: -l check-fedora \ Line 112: -l check-updates \ Line 113: -l check-updates-testing \ -- To view, visit http://gerrit.ovirt.org/24802 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I762abf97c9020301a388f7d83c7d1e41bdf1f062 Gerrit-PatchSet: 10 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Kiril Nesenko <[email protected]> Gerrit-Reviewer: David Caro <[email protected]> Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <[email protected]> Gerrit-Reviewer: Eyal Edri <[email protected]> Gerrit-Reviewer: Kiril Nesenko <[email protected]> Gerrit-Reviewer: Ohad Basan <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
