Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: added jrs pro edition deploy steps ......................................................................
Patch Set 9: (1 comment) http://gerrit.ovirt.org/#/c/25030/9/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py: Line 310: os.path.join( Line 311: '/', Line 312: self._reportsProRelativePath, Line 313: ), Line 314: '' > It's a replace. comma is not needed and cause trouble. should be: xxx( xxx, '', <---- comma always in python! ) Line 315: ) Line 316: node.setContent(nodeContent) Line 317: else: Line 318: with oreportsutil.XMLDoc(dwhdatasource) as xml: -- To view, visit http://gerrit.ovirt.org/25030 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3a3f36e11d0450c031de6da6c6470024534c60e1 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
