Yaniv Dary has posted comments on this change.

Change subject: packaging: setup: added jrs pro edition deploy steps
......................................................................


Patch Set 7:

(1 comment)

http://gerrit.ovirt.org/#/c/25030/7/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py
File 
packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py:

Line 636:         # to be a new absulote path, had to concat the path strings.
Line 637:         #
Line 638:         self._dwhdatasource = os.path.join(
Line 639:             dwhdatasourceexport,
Line 640:             'resources' +
> should not be an issue, check it out, tell me where the problem is.
from the docs (http://docs.python.org/2/library/os.path.html):
If any component is an absolute path, all previous components (on Windows, 
including the previous drive letter, if there was one) are thrown away, and 
joining continues.
Line 641:             self._reportsProRelativePath,
Line 642:             'reports_resources',
Line 643:             'JDBC',
Line 644:             'data_sources',


-- 
To view, visit http://gerrit.ovirt.org/25030
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3a3f36e11d0450c031de6da6c6470024534c60e1
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Yaniv Dary <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yaniv Dary <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to