Lior Vernia has posted comments on this change. Change subject: webadmin: Adding Quota column to the Disk tab ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/25068/2/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SystemTreeModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SystemTreeModel.java: Line 439: dataCenterItem.setApplicationMode(ApplicationMode.VirtOnly); Line 440: dataCenterItem.setTitle(getDataCenters().get(count).getName()); Line 441: dataCenterItem.setEntity(getDataCenters().get(count)); Line 442: dataCentersItem.addChild(dataCenterItem); Line 443: treeItemById.put(getDataCenters().get(count).getId(), dataCenterItem); > since it's an arraylist, it will not make any performance impact, but I agr Yeah, I was thinking more from a readability or "error-proneness" point of view. Line 444: Line 445: SystemTreeItemModel storagesItem = new SystemTreeItemModel(); Line 446: storagesItem.setType(SystemTreeItemType.Storages); Line 447: storagesItem.setApplicationMode(ApplicationMode.VirtOnly); -- To view, visit http://gerrit.ovirt.org/25068 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2332da722396a16aca9545b9ef0532ebc84d8d5e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kobi Ianko <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Kobi Ianko <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
