Kobi Ianko has posted comments on this change. Change subject: webadmin: Adding Quota column to the Disk tab ......................................................................
Patch Set 1: (2 comments) comments on patch 1 http://gerrit.ovirt.org/#/c/25068/1/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/disks/DisksViewColumns.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/disks/DisksViewColumns.java: Line 56: Line 57: String value = null; Line 58: if (object.getDiskStorageType() == DiskStorageType.IMAGE) { Line 59: DiskImage diskImage = (DiskImage) object; Line 60: value = diskImage.getQuotaName(); > I have no idea, I don't know much about disk quotas, just saw that it's a c it's possible with template I'll need to fix my code to support it :( Line 61: } Line 62: return value; Line 63: } Line 64: }; http://gerrit.ovirt.org/#/c/25068/1/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabDiskView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabDiskView.java: Line 180: DisksViewColumns.lunProductIdColumn, constants.productIdSanStorage(), luns, Line 181: "100px"); //$NON-NLS-1$ Line 182: Line 183: getTable().ensureColumnPresent( Line 184: DisksViewColumns.qoutaColumn, constants.qoutaDisk(), (all || images || luns) && isQuotaVisible, "120px"); //$NON-NLS-1$ > But it is a "different kind" of empty cell - for disks it means no quota wa because it's a table in case we select "All", we will have a cell on a LUN row. the only solution I can think of is to write "N/A" but this will make it unpretty when LUN radio is selected(all the rows will have N/A). so we will need to hide it when LUN is selected, this could be confusing for a user that switches from LUN to All and back. both solutions are an option... bottom line, I'm fine with this solution, but also with the "N/A" in All mode and hide in LUN mode, you have more experience with the system here, so if you'd like I'll change it. do you know of other places in the system we use N/A (or similar)? Line 185: Line 186: getTable().ensureColumnPresent( Line 187: DisksViewColumns.descriptionColumn, constants.descriptionDisk(), all || images || luns, Line 188: "90px"); //$NON-NLS-1$ -- To view, visit http://gerrit.ovirt.org/25068 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2332da722396a16aca9545b9ef0532ebc84d8d5e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kobi Ianko <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Kobi Ianko <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
