Michael Kublin has posted comments on this change.
Change subject: core:Support move of shareable disk
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(4 inline comments)
Bug in locking mechanism
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java
Line 73: && checkCanBeMoveInVm() && checkIfNeedToBeOverride()
wrong place for lock
Line 205: List<VM> listVms =
getVmDAO().getForImageGroup(getImage().getId());
that query is used twice, reasons ?
Line 215: canMoveDisk = false;
break;
Line 349: for (VM vm : listVms) {
that code is just wrong..., it is just showing that u not exactly understand a
locking mechanism, next time if you are doing a change please add me as reviewer
--
To view, visit http://gerrit.ovirt.org/4492
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8c59562fdd45cea4628c1e40e65713581647f86f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
