Maor Lipchuk has posted comments on this change.
Change subject: core:Support move of shareable disk
......................................................................
Patch Set 2: (4 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java
Line 73: && checkCanBeMoveInVm() && checkIfNeedToBeOverride()
There is actually already a bug that I'm trying to fix here,
before the change if the validation was failed in one of the conditions above
after we aquired the lock then the disk was locked forever, since the lock was
free only after the execute was ended.
Where do you suggest I should aquire the lock?
Line 205: List<VM> listVms =
getVmDAO().getForImageGroup(getImage().getId());
You got a point, I will refactor it to be used as a cache.
Line 215: canMoveDisk = false;
don't need it, its a while loop with canMoveDisk as an indication
Line 349: for (VM vm : listVms) {
ok, How should I use the locking mechanism for multiple VMs?
--
To view, visit http://gerrit.ovirt.org/4492
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8c59562fdd45cea4628c1e40e65713581647f86f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
