Sandro Bonazzola has posted comments on this change. Change subject: bin: add the host to a specific cluster ......................................................................
Patch Set 7: (2 comments) Thanks Meital, added just a comment about adding valid values to the dialog. Didi, what do you think? http://gerrit.ovirt.org/#/c/25456/7/src/plugins/ovirt-hosted-engine-setup/engine/add_host.py File src/plugins/ovirt-hosted-engine-setup/engine/add_host.py: Line 421: cluster_name = self.dialog.queryString( Line 422: name='cluster_name', Line 423: note=_( Line 424: 'Enter the cluster that you want to add the host ' Line 425: 'to [@DEFAULT@]: ' I suggest 'to (@VALUES@) [@DEFAULT@]: ' Line 426: ), Line 427: prompt=True, Line 428: default=cluster_name, Line 429: ) Line 424: 'Enter the cluster that you want to add the host ' Line 425: 'to [@DEFAULT@]: ' Line 426: ), Line 427: prompt=True, Line 428: default=cluster_name, validValues=','.join(cluster_l), Line 429: ) Line 430: engine_api.hosts.add( Line 431: self._ovirtsdk_xml.params.Host( Line 432: name=self.environment[ -- To view, visit http://gerrit.ovirt.org/25456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I00167e70296645e5cf732b64d87efa1cf66ca783 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Meital Bourvine <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
