Yair Zaslavsky has posted comments on this change. Change subject: aaa: Change builtin authenticators and directories initialization ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/25741/2/backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionManager.java File backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionManager.java: Line 233: for (ExtensionEntry entry : loadedEntries.values()) { Line 234: //Engine local config might override the enabled property of the configuration Line 235: // if a proper entry exists at the engine config. Line 236: entry.enabled = config.getBoolean(ENGINE_EXTENSION_ENABLED + entry.getName(), entry.enabled); Line 237: if (entry.enabled && entry.extension == null) { > well, we have one public load method for loading collection of properties. Btw, if we synchronize load, shouldn't we synchronize log as well? log accesses the same data structure. On the other hand, can't we assume that only InitOnStartup will call "load"? Line 238: try { Line 239: entry.extension = (Extension) lookupService( Line 240: Extension.class, Line 241: entry.getConfig().getProperty(CLASS), -- To view, visit http://gerrit.ovirt.org/25741 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8513cb992c5becef7e83c04a8da8bc7f1622348 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
