Yair Zaslavsky has posted comments on this change.

Change subject: aaa: Change builtin authenticators and directories 
initialization
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/25741/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java:

Line 116:         authConfig.put(ExtensionManager.NAME, 
"builtin-authn-internal");
Line 117:         authConfig.put("ovirt.engine.aaa.authn.profile.name", 
"internal");
Line 118:         authConfig.put("ovirt.engine.aaa.authn.authz.plugin", 
"builtin-authz-internal");
Line 119:         authConfig.put("ovirt.engine.aaa.authn.user", Config.<String> 
getValue(ConfigValues.AdminUser));
Line 120:         authConfig.put("ovirt.engine.aaa.authn.password", 
Config.<String> getValue(ConfigValues.AdminPassword));
> Did you mean an extension property? if not, where do you want this new sens
please also provide a usage example for the new key of sensitive-keys - is it a 
boolean flag? a command delimited string containing the names of the 
sensitive-keys?
In addition, about renaming, I guess you meant the above 2 users and password 
keys.
Line 121:         results.add(authConfig);
Line 122: 
Line 123:         Properties dirConfig = new Properties();
Line 124:         dirConfig.put(ExtensionManager.CLASS, 
"org.ovirt.engine.extensions.aaa.builtin.internal.InternalDirectory");


-- 
To view, visit http://gerrit.ovirt.org/25741
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id8513cb992c5becef7e83c04a8da8bc7f1622348
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to