Dhandapani Gopal has posted comments on this change.
Change subject: engine: Gluster Host Remove Command
......................................................................
Patch Set 3: (5 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVdsCommand.java
Line 61: return false;
Used returnValue=false
Line 106: errorType = AuditLogType.USER_FAILED_REMOVE_VDS;
I added the errorType in class level, so that if any failure the error will be
logged.
Line 149: VDSGroup vdsGroup = getVdsGroupDAO().get(getVdsGroupId());
Done
Line 175: if (isGlusterEnabled() && !hasVolumeOnServer()) {
Done
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterVolumeDaoDbFacadeImpl.java
Line 404: public Integer getBrickCountByServerId(Guid serverId) {
Created new stored procedure. Moved the method to GlusterBrickDao, since it is
related to bricks. Added the test in GlusterBrickDaoTest.
--
To view, visit http://gerrit.ovirt.org/4512
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0c82837ba911d96a1ab10d11f62d43e9e8ad4d90
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dhandapani Gopal <[email protected]>
Gerrit-Reviewer: Dhandapani Gopal <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Selvasundaram <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
