Omer Frenkel has posted comments on this change.
Change subject: engine: Gluster Host Remove Command
......................................................................
Patch Set 6: (3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVdsCommand.java
Line 102: .RunVdsCommand(VDSCommandType.RemoveVds, new
RemoveVdsVDSCommandParameters(getVdsId()));
on your next rebase,
returnValue is not needed any more, no point to keep it
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommand.java
Line 181
since now its public, maybe not needed anymore
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AttachNetworkToVdsGroupCommandTest.java
Line 99: public VdsGroupDAO getVdsGroupDAO() {
since now its public, maybe not needed anymore
--
To view, visit http://gerrit.ovirt.org/4512
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0c82837ba911d96a1ab10d11f62d43e9e8ad4d90
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dhandapani Gopal <[email protected]>
Gerrit-Reviewer: Dhandapani Gopal <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Selvasundaram <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
