Ofer Schreiber has posted comments on this change.
Change subject: packaging: Build and run with Fedora 17 jboss-as
......................................................................
Patch Set 5: Fails
(8 inline comments)
Some more notes about the spec
....................................................
File packaging/fedora/spec/ovirt-engine.spec.in
Line 595: %config(noreplace) %attr(-, %{engine_user}, %{engine_group})
%{engine_etc_dir}/engine-service-users.properties
I'm not sure there's a reason to mark all these files as config
Line 690: %attr(-, %{engine_user}, %{engine_group}) %{engine_pki_dir}/serial.txt
Both files MUST be conf (they change after host installation)
Line 766: #%config(noreplace)
%{engine_ear_dir}/userportal.war/org.ovirt.engine.ui.userportal.UserPortal/consoles/spice/usbfilter.txt
Why putting the #?
Line 798: %config(noreplace)
%{engine_etc_dir}/engine-config/engine-config.*properties
Any reason for this one to be config?
Line 799: %config(noreplace) %{engine_etc_dir}/engine-config/log4j.xml
same?
Line 804: %config(noreplace) %{engine_etc_dir}/engine-manage-domains/log4j.xml
Any reason for this one to be config?
Line 821: %config(noreplace) %{engine_etc_dir}/notifier/log4j.xml
Any reason for this one to be config?
Line 830: %changelog
I think you deserve a changelog attr
--
To view, visit http://gerrit.ovirt.org/4416
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5cda15e5219d1b6c8e8306fc7b4f196e6afc66b1
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
