Juan Hernandez has posted comments on this change.
Change subject: packaging: Build and run with Fedora 17 jboss-as
......................................................................
Patch Set 5: (7 inline comments)
The warning about private JBoss modules is just that, a warning.
....................................................
File packaging/fedora/spec/ovirt-engine.spec.in
Line 595: %config(noreplace) %attr(-, %{engine_user}, %{engine_group})
%{engine_etc_dir}/engine-service-users.properties
The equivalent files in the JBoss packages are marked as configuration as well.
The sysconfig file is designed to be configuration.
The engine-service.xml is modified by engine-setup, so it has to be marked as
configuration, otherwise it would be overwritten during updates. Going forward
we could modify engine-setup so that there is no need to modify this file, then
we can move it out of /etc and don't mark is a configuration. However it won't
be easy, because the application server loads and *saves* it each run.
The engine-service-logging.properties and engine-service-users.properties are
not modified during setup. I am not against moving them out of /etc and
removing the %config.
Line 690: %attr(-, %{engine_user}, %{engine_group}) %{engine_pki_dir}/serial.txt
In a previous iteration of this change I marked these files as %ghost, which I
think is better than %config for this use case, but I forgot to redo that. I we
mark them as %config users running rpm -qc may think that they can modify them.
Is it ok if I mark them as %ghost again?
Line 766: #%config(noreplace)
%{engine_ear_dir}/userportal.war/org.ovirt.engine.ui.userportal.UserPortal/consoles/spice/usbfilter.txt
Because I am still thinking a way to fix this ugliness :-)
Line 799: %config(noreplace) %{engine_etc_dir}/engine-config/log4j.xml
Same, but for log4j configuration files I think that they are configuration.
Line 804: %config(noreplace) %{engine_etc_dir}/engine-manage-domains/log4j.xml
Same as before.
Line 821: %config(noreplace) %{engine_etc_dir}/notifier/log4j.xml
Same as before.
Line 830: %changelog
Maybe in next iteration ;-)
--
To view, visit http://gerrit.ovirt.org/4416
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5cda15e5219d1b6c8e8306fc7b4f196e6afc66b1
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
