Roy Golan has posted comments on this change. Change subject: webadmin: Add boot time to Host General tab ......................................................................
Patch Set 7: (2 comments) http://gerrit.ovirt.org/#/c/25879/7/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java: Line 859: public Date getBootTime() { Line 860: return bootTime; Line 861: } Line 862: Line 863: public void setBootTime(Long value) { > value can be null? i.e. can 'vds.getBootTime()' return null? backend side is probably a Long in order not to override bootTime values which are not reported? Line 864: /* Factor by 1000 since Date works with millis since epoch and we store seconds (as provided by machines) */ Line 865: if (bootTime == null) { Line 866: bootTime = new Date(value * 1000); Line 867: } Line 862: Line 863: public void setBootTime(Long value) { Line 864: /* Factor by 1000 since Date works with millis since epoch and we store seconds (as provided by machines) */ Line 865: if (bootTime == null) { Line 866: bootTime = new Date(value * 1000); instead of magic 1000 number use TimeUnit.SECONDS.toMillis (value) TimeUnit.MILLIS.toSeconds(bootTime.getTime()) Line 867: } Line 868: else if ((bootTime.getTime() / 1000) != value) { Line 869: bootTime.setTime(value * 1000); Line 870: } -- To view, visit http://gerrit.ovirt.org/25879 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I157042522209f5917bcdd951b9259f08cabbd907 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
