Daniel Erez has posted comments on this change. Change subject: webadmin: Add boot time to Host General tab ......................................................................
Patch Set 10: Code-Review+1 (2 comments) just minor comments http://gerrit.ovirt.org/#/c/25879/10/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java: Line 862: } Line 863: Line 864: public void setBootTime(Long value) { Line 865: /* Factor by 1000 since Date works with millis since epoch and we store seconds (as provided by machines) */ Line 866: if (value == null) { formatter Line 867: if (bootTime == null) { Line 868: return; Line 869: } Line 870: bootTime = null; Line 864: public void setBootTime(Long value) { Line 865: /* Factor by 1000 since Date works with millis since epoch and we store seconds (as provided by machines) */ Line 866: if (value == null) { Line 867: if (bootTime == null) { Line 868: return; consider removing this if statement - it's probably just for avoiding redundant null assignment, but not sure it's worth compromising readability for that... :) Line 869: } Line 870: bootTime = null; Line 871: } else { Line 872: if (bootTime == null) { -- To view, visit http://gerrit.ovirt.org/25879 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I157042522209f5917bcdd951b9259f08cabbd907 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
