Yaniv Dary has posted comments on this change. Change subject: reports: br21 report - added comments to queries ......................................................................
Patch Set 4: (2 comments) http://gerrit.ovirt.org/#/c/25136/4/packaging/ovirt-reports/resources/Reports/Inventory/Storage_Domain_Report_BR21_files/full+details+br21.jrxml.data File packaging/ovirt-reports/resources/Reports/Inventory/Storage_Domain_Report_BR21_files/full details br21.jrxml.data: Line 100: THEN CAST ( CAST($P{P_Start_Date} AS date ) + interval '1 month' - interval '1 day' AS date) Line 101: WHEN $P{P_Period} = 2 Line 102: THEN CAST ( CAST($P{P_Start_Date} AS date ) + interval '3 month' - interval '1 day' AS date) Line 103: WHEN $P{P_Period} = 3 Line 104: THEN CAST ( CAST($P{P_Start_Date} AS date ) + interval '1 year' - interval '1 day' AS date) The lines above are too long drop a line at the casting. Line 105: END AS end_date, Line 106: ( Line 107: SELECT DISTINCT Line 108: COALESCE ( Line 137: CAST ( $P{P_DataCenter_ID} AS uuid ) Line 138: AND v3_4_configuration_history_datacenters.history_id IN ( Line 139: SELECT MAX(a.history_id) Line 140: FROM v3_4_configuration_history_datacenters AS a Line 141: GROUP BY a.datacenter_id)]]> drop a line at in close. Line 142: </queryString> Line 143: <field name="datacenter_name" class="java.lang.String"/> Line 144: <field name="datacenter_delete_date" class="java.sql.Timestamp"/> Line 145: <field name="storage_name" class="java.lang.String"/> -- To view, visit http://gerrit.ovirt.org/25136 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6011ea7812ab7abdf5367da5f61c44a8bc2d6d3c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Shirly Radco <[email protected]> Gerrit-Reviewer: Shirly Radco <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
