Shahar Havivi has posted comments on this change. Change subject: core: Static IP is set as none bootproto for cloud-init ......................................................................
Patch Set 1: (2 comments) Yes you right Moti, Adding it in the next patch http://gerrit.ovirt.org/#/c/26258/1/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CloudInitHandler.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CloudInitHandler.java: Line 131: Line 132: for (VmInitNetwork iface: networks) { Line 133: output.append("iface " + iface.getName() + " inet " Line 134: + iface.getBootProtocol().getDisplayName() + "\n"); Line 135: if (!StringUtils.isEmpty(iface.getIp())) { > you can replace it with: Done Line 136: output.append(" address " + iface.getIp() + "\n"); Line 137: } Line 138: if (!StringUtils.isEmpty(iface.getNetmask())) { Line 139: output.append(" netmask " + iface.getNetmask() + "\n"); Line 134: + iface.getBootProtocol().getDisplayName() + "\n"); Line 135: if (!StringUtils.isEmpty(iface.getIp())) { Line 136: output.append(" address " + iface.getIp() + "\n"); Line 137: } Line 138: if (!StringUtils.isEmpty(iface.getNetmask())) { > same here Done Line 139: output.append(" netmask " + iface.getNetmask() + "\n"); Line 140: } Line 141: if (!StringUtils.isEmpty(iface.getGateway())) { Line 142: output.append(" gateway " + iface.getGateway() + "\n"); -- To view, visit http://gerrit.ovirt.org/26258 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I53159a6ead92d890f7abe2ec78196bb967994a5f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
