Juan Hernandez has posted comments on this change. Change subject: core: Static IP is set as none bootproto for cloud-init ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/26258/2/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java File backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java: Line 1150: if (model.isSetIp()) { Line 1151: // If the user set IP but didn't set the boot protocol, we fall for static and not none Line 1152: if (!model.isSetBootProtocol()) { Line 1153: entity.setBootProtocol(NetworkBootProtocol.STATIC_IP); Line 1154: } The API shouldn't contain any business logic. This rule should go in the backend, the API should just pass whatever the user provided. Line 1155: if (model.getIp().isSetAddress()) { Line 1156: entity.setIp(model.getIp().getAddress()); Line 1157: } Line 1158: if (model.getIp().isSetNetmask()) { -- To view, visit http://gerrit.ovirt.org/26258 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I53159a6ead92d890f7abe2ec78196bb967994a5f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
