Yair Zaslavsky has posted comments on this change. Change subject: aaa: use new api ......................................................................
Patch Set 8: (5 comments) http://gerrit.ovirt.org/#/c/26427/8/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java: Line 114: authConfig.put(Base.ConfigKeys.NAME, "builtin-authn-internal"); Line 115: authConfig.put(Base.ConfigKeys.PROVIDES, Authn.class.getName()); Line 116: authConfig.put(Base.ConfigKeys.MODULE, "org.ovirt.engine.extensions.builtin"); Line 117: authConfig.put(Base.ConfigKeys.CLASS, Line 118: "org.ovirt.engine.extensions.aaa.builtin.internal.InternalAuthenticator"); I know this isn't your fault , but Maybe InternalAuthenticator.class.getName() ? Line 119: authConfig.put("ovirt.engine.aaa.authn.profile.name", "internal"); Line 120: authConfig.put("ovirt.engine.aaa.authn.authz.plugin", "internal"); Line 121: authConfig.put("config.authn.user.name", Config.<String> getValue(ConfigValues.AdminUser)); Line 122: authConfig.put("config.authn.user.password", Config.<String> getValue(ConfigValues.AdminPassword)); Line 124: ExtensionsManager.getInstance().load(authConfig); Line 125: Line 126: Properties dirConfig = new Properties(); Line 127: dirConfig.put(Base.ConfigKeys.NAME, "internal"); Line 128: dirConfig.put(Base.ConfigKeys.PROVIDES, Authz.class.getName()); here - not sure if I would go for Authz.class.getName - why would you want to have a full class name here for what the extension provides? isn't plain "authz" or "authn" sufficient? Line 129: dirConfig.put(Base.ConfigKeys.MODULE, "org.ovirt.engine.extensions.builtin"); Line 130: dirConfig.put(Base.ConfigKeys.CLASS, "org.ovirt.engine.extensions.aaa.builtin.internal.InternalDirectory"); Line 131: dirConfig.put("config.authz.user.name", Config.<String> getValue(ConfigValues.AdminUser)); Line 132: ExtensionsManager.getInstance().load(dirConfig); Line 126: Properties dirConfig = new Properties(); Line 127: dirConfig.put(Base.ConfigKeys.NAME, "internal"); Line 128: dirConfig.put(Base.ConfigKeys.PROVIDES, Authz.class.getName()); Line 129: dirConfig.put(Base.ConfigKeys.MODULE, "org.ovirt.engine.extensions.builtin"); Line 130: dirConfig.put(Base.ConfigKeys.CLASS, "org.ovirt.engine.extensions.aaa.builtin.internal.InternalDirectory"); same as before. Line 131: dirConfig.put("config.authz.user.name", Config.<String> getValue(ConfigValues.AdminUser)); Line 132: ExtensionsManager.getInstance().load(dirConfig); Line 133: } Line 134: http://gerrit.ovirt.org/#/c/26427/8/backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionsManager.java File backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionsManager.java: Line 223: ) Line 224: ); Line 225: Line 226: entry.extension.getContext().put( Line 227: TRACE_LOG_CONTEXT_KEY, can you please elaborate what this key is for? Line 228: LoggerFactory.getLogger( Line 229: String.format( Line 230: "%1$s.%2$s.%3%s", Line 231: traceLog.getName(), Line 237: Line 238: dumpConfig(entry.extension); Line 239: Line 240: entry.activated = true; Line 241: } catch (Exception ex) { Would you like to use here the new Exceptions you introduced? or do you intend to use them somewhere else? Line 242: log.error( Line 243: String.format( Line 244: "Error in activating extension %1$s. Exception message is %2$s", Line 245: entry.name, -- To view, visit http://gerrit.ovirt.org/26427 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d170d5dda990fd85e9843ecbb4909749a88df75 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
