Yair Zaslavsky has posted comments on this change. Change subject: aaa: use new api ......................................................................
Patch Set 8: (2 comments) http://gerrit.ovirt.org/#/c/26427/8/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthenticationProfileRepository.java File backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthenticationProfileRepository.java: Line 15: import org.ovirt.engine.core.extensions.mgr.ExtensionProxy; Line 16: Line 17: public class AuthenticationProfileRepository { Line 18: Line 19: private static final String AUTHN_SERVICE = Authn.class.getName(); see my suggestions before on the service names. Line 20: private static final String AUTHN_AUTHZ_PLUGIN = Authz.class.getName(); Line 21: Line 22: Line 23: private static volatile AuthenticationProfileRepository instance = null; Line 81: Line 82: for (ExtensionProxy authnExtension : ExtensionsManager.getInstance().getProvidedExtensions(AUTHN_SERVICE)) { Line 83: registerProfile( Line 84: new AuthenticationProfile( Line 85: (Authenticator) (Extension) authnExtension, Why this double cast? Can't getExtensionByName return an Extension and have us one cast? not sure I understood why this is needed. Line 86: (Directory) (Extension) ExtensionsManager.getInstance().getExtensionByName( Line 87: authnExtension.getContext().<Properties>get(Base.ContextKeys.CONFIGURATION).getProperty( Line 88: AUTHN_AUTHZ_PLUGIN Line 89: ) -- To view, visit http://gerrit.ovirt.org/26427 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d170d5dda990fd85e9843ecbb4909749a88df75 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
