Yaniv Dary has posted comments on this change. Change subject: reports: br47 report - added comments to queries ......................................................................
Patch Set 4: (4 comments) http://gerrit.ovirt.org/#/c/25060/4/packaging/ovirt-reports/resources/Reports/Inventory/storage_domains_inventory_br47_files/storage_domains_inventory_br47_jrxml.data File packaging/ovirt-reports/resources/Reports/Inventory/storage_domains_inventory_br47_files/storage_domains_inventory_br47_jrxml.data: Line 104: enum_translator_default.enum_key, Line 105: enum_translator_default.value, Line 106: enum_translator_localized.value_localized Line 107: FROM enum_translator AS enum_translator_default Line 108: LEFT OUTER JOIN ( Needs to be indented Line 109: SELECT Line 110: enum_type, Line 111: enum_key, Line 112: value AS value_localized Line 121: enum_translator_default.enum_key Line 122: ) Line 123: WHERE language_code = 'en_US' Line 124: ) Line 125: AS a Please indent correctly Line 126: ON ( Line 127: storage_domain_type = a.enum_key Line 128: AND a.enum_type = 'STORAGE_DOMAIN_TYPE' Line 129: ) Line 133: enum_translator_default.enum_key, Line 134: enum_translator_default.value, Line 135: enum_translator_localized.value_localized Line 136: FROM enum_translator AS enum_translator_default Line 137: LEFT OUTER JOIN ( same Line 138: SELECT Line 139: enum_type, Line 140: enum_key, Line 141: value AS value_localized Line 150: enum_translator_default.enum_key Line 151: ) Line 152: WHERE language_code = 'en_US' Line 153: ) Line 154: AS b same Line 155: ON ( Line 156: storage_type = b.enum_key Line 157: AND b.enum_type = 'STORAGE_TYPE' Line 158: ) -- To view, visit http://gerrit.ovirt.org/25060 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ce5b40141765d1e25637741b6c5a02b12b208b7 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Shirly Radco <[email protected]> Gerrit-Reviewer: Shirly Radco <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
