Yaniv Dary has posted comments on this change. Change subject: reports: br47 report - added comments to queries ......................................................................
Patch Set 5: (4 comments) http://gerrit.ovirt.org/#/c/25060/5/packaging/ovirt-reports/resources/Reports/Inventory/storage_domains_inventory_br47_files/chart.data File packaging/ovirt-reports/resources/Reports/Inventory/storage_domains_inventory_br47_files/chart.data: Line 32: ) Line 33: AS total_size Line 34: FROM v3_4_configuration_history_storage_domains Line 35: LEFT OUTER JOIN v3_4_statistics_storage_domains_resources_usage_samples AS samples Line 36: ON ( should be indented by one more tab Line 37: v3_4_configuration_history_storage_domains.storage_domain_id = Line 38: samples.storage_domain_id Line 39: AND samples.history_id IN ( Line 40: SELECT MAX ( a.history_id ) Line 53: ) Line 54: ) Line 55: WHERE Line 56: v3_4_configuration_history_storage_domains.storage_domain_id = Line 57: CAST ( $P{P_StorageDomain_ID} AS uuid ) should be indented by one more tab Line 58: AND v3_4_configuration_history_storage_domains.history_id IN ( Line 59: SELECT MAX ( a.history_id ) Line 60: FROM v3_4_configuration_history_storage_domains AS a Line 61: GROUP BY a.storage_domain_id http://gerrit.ovirt.org/#/c/25060/5/packaging/ovirt-reports/resources/Reports/Inventory/storage_domains_inventory_br47_files/full+details.jrxml.data File packaging/ovirt-reports/resources/Reports/Inventory/storage_domains_inventory_br47_files/full details.jrxml.data: Line 59: AS storage_domain_type Line 60: FROM v3_4_configuration_history_datacenters Line 61: WHERE Line 62: v3_4_configuration_history_datacenters.datacenter_id = Line 63: CAST ( $P{P_DataCenter_ID} AS uuid ) should be indented by one more tab Line 64: AND v3_4_configuration_history_datacenters.history_id IN ( Line 65: SELECT MAX(a.history_id) Line 66: FROM v3_4_configuration_history_datacenters AS a Line 67: GROUP BY a.datacenter_id http://gerrit.ovirt.org/#/c/25060/5/packaging/ovirt-reports/resources/Reports/Inventory/storage_domains_inventory_br47_files/storage_domains_inventory_br47_jrxml.data File packaging/ovirt-reports/resources/Reports/Inventory/storage_domains_inventory_br47_files/storage_domains_inventory_br47_jrxml.data: Line 220: -- available disk size, used disk size and total disk size Line 221: Line 222: SELECT Line 223: v3_4_configuration_history_storage_domains.storage_domain_id, Line 224: COALESCE ( this is only three spaces. tab needs 4. Line 225: samples.available_disk_size_gb, Line 226: daily.available_disk_size_gb Line 227: ) Line 228: AS available_disk_size_gb, -- To view, visit http://gerrit.ovirt.org/25060 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ce5b40141765d1e25637741b6c5a02b12b208b7 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Shirly Radco <[email protected]> Gerrit-Reviewer: Shirly Radco <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
