Yaniv Bronhaim has posted comments on this change. Change subject: core: Host's Compatibility Version doesn't match the Cluster's Compatibility Version ......................................................................
Patch Set 7: Code-Review+1 (2 comments) http://gerrit.ovirt.org/#/c/26061/7/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HandleVdsVersionCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HandleVdsVersionCommand.java: Line 58: } Line 59: Line 60: // Check if vdsm supports the current engine, and that it supports the cluster version Line 61: if (!isEngineSupportedByVdsm) { Line 62: reportNonOperationReason(NonOperationalReason.VERSION_INCOMPATIBLE_WITH_CLUSTER, > Because I don't know what are the implications of that on other parts of th i can't think of any implications .. but this somehow fixed with the new constant. so im leaving it Line 63: partialVdcVersion.toString(), Line 64: vdsmVersion.toString()); Line 65: } Line 66: else if (!VersionSupport.checkClusterVersionSupported(cluster.getcompatibility_version(), vds)) { http://gerrit.ovirt.org/#/c/26061/7/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetNonOperationalVdsCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetNonOperationalVdsCommand.java: Line 120: return AuditLogType.VDS_RECOVER_FAILED; Line 121: case KVM_NOT_RUNNING: Line 122: return AuditLogType.VDS_RUN_IN_NO_KVM_MODE; Line 123: case VERSION_INCOMPATIBLE_WITH_CLUSTER: Line 124: return AuditLogType.VDSM_VERSION_INCOMPATIBLE_WITH_ENGINE_VERSION; this is odd ... but well, if that's how it is Line 125: case CLUSTER_VERSION_INCOMPATIBLE_WITH_CLUSTER: Line 126: return AuditLogType.VDS_CLUSTER_VERSION_NOT_SUPPORTED; Line 127: case VM_NETWORK_IS_BRIDGELESS: Line 128: return AuditLogType.VDS_SET_NON_OPERATIONAL_VM_NETWORK_IS_BRIDGELESS; -- To view, visit http://gerrit.ovirt.org/26061 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1a899462ce3d74f3b1570a23c10ce38aeae1a18e Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
