Liran Zelkha has posted comments on this change. Change subject: core: Host's Compatibility Version doesn't match the Cluster's Compatibility Version ......................................................................
Patch Set 7: (1 comment) http://gerrit.ovirt.org/#/c/26061/7/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HandleVdsVersionCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HandleVdsVersionCommand.java: Line 58: } Line 59: Line 60: // Check if vdsm supports the current engine, and that it supports the cluster version Line 61: if (!isEngineSupportedByVdsm) { Line 62: reportNonOperationReason(NonOperationalReason.VERSION_INCOMPATIBLE_WITH_CLUSTER, > errr, probably i confused you. all i meant is to have the right report here That's a status change that I'm not comfortable in doing. The audits and everything is stored nicely. Changing the enum name might have implications that we don't understand and will make this patch more problematic. It is the same reason as before, so why change it? Line 63: partialVdcVersion.toString(), Line 64: vdsmVersion.toString()); Line 65: } Line 66: else if (!VersionSupport.checkClusterVersionSupported(cluster.getcompatibility_version(), vds)) { -- To view, visit http://gerrit.ovirt.org/26061 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1a899462ce3d74f3b1570a23c10ce38aeae1a18e Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
