Michael Pasternak has posted comments on this change.
Change subject: restapi: non admin user api - Filtering user queries (#783087)
......................................................................
Patch Set 5: I would prefer that you didn't submit this
(3 inline comments)
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BaseBackendResource.java
Line 314: filter = Boolean.valueOf(filterVar.iterator().next());
1. what if value is not bool? exception? you should be able to recover from it
nicely
2. you doing unneeded boxing, by returning class where primitive expected, use
Boolean.parseBoolean() instead
3. please cache the value of the header, there might be few queries during the
hit calling isFiltered(), - you don't need to preform header retrieval and
casting
every time.
....................................................
File
backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendResourceTest.java
Line 2
can you pls. explain why this change is needed (move of the all code)?
....................................................
File
backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/test/util/TestHelper.java
Line 34: method = clz.getMethod("is" + name);
what method starts with 'is' and not bool?
--
To view, visit http://gerrit.ovirt.org/4360
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e5e23cbb8e883f6005f69be46fa528ac6e7518c
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Asaf Shakarchi <[email protected]>
Gerrit-Reviewer: Asaf Shakarchi <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
