Asaf Shakarchi has posted comments on this change. Change subject: restapi: non admin user api - Filtering user queries (#783087) ......................................................................
Patch Set 5: (2 inline comments) Pushing a new changeset now. .................................................... File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BaseBackendResource.java Line 314: filter = Boolean.valueOf(filterVar.iterator().next()); 1. Please read valueOf/parseBoolean javadoc, if string value is not 'true' then it parsed as false. 2. Irrelevant because of point 3. 3. Fair enough. .................................................... File backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendResourceTest.java Line 2 Most of the generic testing code moved to a new class named 'AbstractBackendBaseTest' which should provide a way to test base classes such as 'BackendResourceTest' which are not specific resource driven -- To view, visit http://gerrit.ovirt.org/4360 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e5e23cbb8e883f6005f69be46fa528ac6e7518c Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Asaf Shakarchi <[email protected]> Gerrit-Reviewer: Asaf Shakarchi <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> Gerrit-Reviewer: Ori Liel <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
