Alon Bar-Lev has posted comments on this change. Change subject: aaa: Using extensions API in built-in authz and auth ......................................................................
Patch Set 15: (2 comments) http://gerrit.ovirt.org/#/c/26602/15/backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/KerberosLdapAuthz.java File backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/KerberosLdapAuthz.java: Line 97: long addedGroups = 0; Line 98: for (LdapGroup ldapGroup : ldapGroups) { Line 99: if (addedGroups++ < pageSize) { Line 100: results.add(mapLdapGroup(ldapGroup)); Line 101: } > Not sure I fully understood why does it matter. I think you can just return all the ldapGroups and not fake paging. Line 102: } Line 103: return output.mput(Authz.InvokeKeys.QUERY_RESULT, results); Line 104: } Line 105: Line 264: ); Line 265: } Line 266: Line 267: private String generateFromFilter(ExtMap queryFilterRecord) { Line 268: StringBuilder result = new StringBuilder(); > if i use a single StringBuilder allover, it will make the recusion complex, how will it make it more complex? I do not understand... from memory, the following should work: private String generateFromFilter(StringBuilder query, ExtMap queryFilterRecord) { List<ExtMap> filter = queryFilterRecord.<List<ExtMap>> get(Authz.QueryFilterRecord.FILTER); if (filter == null) { ExtKey key = queryFilterRecord.<ExtKey> get(Authz.QueryFilterRecord.KEY); query.append(); //same } else { query.append(); // same for (ExtMap filterRecord : filter) { generateFromFilter(query, filterRecord); } query.append(); // same } } Line 269: List<ExtMap> filter = queryFilterRecord.<List<ExtMap>> get(Authz.QueryFilterRecord.FILTER); Line 270: if (filter == null) { Line 271: ExtKey key = queryFilterRecord.<ExtKey> get(Authz.QueryFilterRecord.KEY); Line 272: result.append( -- To view, visit http://gerrit.ovirt.org/26602 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I916012eab61a96bdb0f366d9dc8462325d7f726f Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
