Alon Bar-Lev has posted comments on this change. Change subject: aaa: Using extensions API in built-in authz and auth ......................................................................
Patch Set 17: (1 comment) http://gerrit.ovirt.org/#/c/26602/17/backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/KerberosLdapAuthn.java File backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/KerberosLdapAuthn.java: Line 84: input.put(Constants.Keys.AUTHZ_NAME, getAuthzName()); Line 85: broker.runAdAction( Line 86: AdActionType.AuthenticateUser, Line 87: new LdapUserPasswordBaseParameters(input, output) Line 88: ); well... you can just put a parameter for the authz name to LdapUserPasswordBaseParameters instead of using the map for this... but well.... ok... anyway it should have been: new LdapUserPasswordBaseParameters(input.mput(Constants.Keys.AUTHZ_NAME, getAuthzName()), output) but you can always extract the getAuthzName() from the input via the context via configuration, so I do not see any reason to add this key. Line 89: // Putting these keys anyway, it's up to BLL to decide if to use them or not Line 90: output.mput( Line 91: Authn.InvokeKeys.USER_MESSAGE, Line 92: configuration.getProperty("config.change.password.msg") -- To view, visit http://gerrit.ovirt.org/26602 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I916012eab61a96bdb0f366d9dc8462325d7f726f Gerrit-PatchSet: 17 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
