Sahina Bose has posted comments on this change. Change subject: core: Added the table vds_deloy_config ......................................................................
Patch Set 1: (5 comments) http://gerrit.ovirt.org/#/c/27028/1/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsDeployConfig.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsDeployConfig.java: Line 5: public class VdsDeployConfig extends IVdcQueryable { Line 6: private static final long serialVersionUID = 3185087852755356867L; Line 7: private int configId; Line 8: private String configName; Line 9: private String configType; Should this be an enum? Line 10: private String configValue; Line 11: Line 12: public int getConfigId() { Line 13: return this.configId; http://gerrit.ovirt.org/#/c/27028/1/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDeployConfigDAODbFacadeImpl.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDeployConfigDAODbFacadeImpl.java: Line 66: .addValue("cfg_type", cfg.getConfigType()) Line 67: .addValue("cfg_value", cfg.getConfigValue()) Line 68: .addValue("cfg_id", cfg.getConfigId()); Line 69: Line 70: getCallsHandler().executeModification("UpdateVdsDeplotConfig", parameterSource); typo? Line 71: } Line 72: Line 73: @Override Line 74: public void remove(int id) { http://gerrit.ovirt.org/#/c/27028/1/backend/manager/modules/dal/src/test/resources/fixtures.xml File backend/manager/modules/dal/src/test/resources/fixtures.xml: Line 6085: <value>2012-12-28 09:27:18</value> Line 6086: <value>2012-12-31 11:54:27</value> Line 6087: </row> Line 6088: </table> Line 6089: TWS Line 6090: <table name="vds_deploy_config"> Line 6091: <column>cfg_id</column> Line 6092: <column>cfg_name</column> Line 6093: <column>cfg_type</column> http://gerrit.ovirt.org/#/c/27028/1/packaging/dbscripts/upgrade/03_05_0330_create_vds_deploy_config_table.sql File packaging/dbscripts/upgrade/03_05_0330_create_vds_deploy_config_table.sql: Line 8: cfg_value VARCHAR(4000) NOT NULL Line 9: ); Line 10: Line 11: -- create index for cfg_name Line 12: CREATE INDEX IDX_vds_deploy_config_cfg_name ON vds_deploy_config(cfg_name); Shouldn't this be a unique index, or a constraint on cfg_name http://gerrit.ovirt.org/#/c/27028/1/packaging/dbscripts/vds_deploy_config_sp.sql File packaging/dbscripts/vds_deploy_config_sp.sql: Line 14: Line 15: Line 16: Line 17: Line 18: Create or replace FUNCTION UpdateVdsDeplotConfig(v_cfg_name VARCHAR(50), UpdateVdsDeployConfig? Line 19: v_cfg_type VARCHAR(30), Line 20: v_cfg_value VARCHAR(50), Line 21: v_cfg_id INTEGER) Line 22: RETURNS VOID -- To view, visit http://gerrit.ovirt.org/27028 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifc58b36dccfd23165dd5b0dfb7c2c86cf261f488 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
