Shubhendu Tripathi has posted comments on this change.

Change subject: core: Added the table vds_deloy_config
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/27028/1/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsDeployConfig.java
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsDeployConfig.java:

Line 5: public class VdsDeployConfig extends IVdcQueryable {
Line 6:     private static final long serialVersionUID = 3185087852755356867L;
Line 7:     private int configId;
Line 8:     private String configName;
Line 9:     private String configType;
> Will introduce an enum for the same
Rather would use org.ovirt.engine.core.common.config.DataType enum
Line 10:     private String configValue;
Line 11: 
Line 12:     public int getConfigId() {
Line 13:         return this.configId;


-- 
To view, visit http://gerrit.ovirt.org/27028
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc58b36dccfd23165dd5b0dfb7c2c86cf261f488
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to