Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: Removing build-conf files on failure ......................................................................
Patch Set 9: (3 comments) http://gerrit.ovirt.org/#/c/27167/9/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py: Line 100: Line 101: def do_changes(self): Line 102: for entry in self._need_restore: Line 103: os.rename(entry['src'], entry['dst']) Line 104: self._restore.append(entry) not sure why we cannot keep this in prepare Line 105: self._dbovirtutils.clearDatabase() Line 106: Line 107: def abort(self): Line 108: self._parent.logger.info(_('Rolling back Reports database schema')) Line 462: parent=self, Line 463: ) Line 464: self.environment[otopicons.CoreEnv.MAIN_TRANSACTION].append( Line 465: self._transaction_element Line 466: ) why do we need this? Line 467: Line 468: def __init__(self, context): Line 469: super(Plugin, self).__init__(context=context) Line 470: self._oreportsutil = None Line 719: 'standalone', Line 720: ) Line 721: Line 722: self._add_transaction_if_not_done_yet() Line 723: self._transaction_element.do_changes() why do we need this? Line 724: Line 725: config = self._jasperConfiguration() Line 726: Line 727: # -- To view, visit http://gerrit.ovirt.org/27167 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2507ea0c6ecd6d0a69f56d0693fcafd21f58992f Gerrit-PatchSet: 9 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
