Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: Removing build-conf files on failure ......................................................................
Patch Set 9: > why not just check at beginning of transaction if file exists and if not just > remove them at end of transaction? > I do not understand the complexity introduced. Before this change, the transaction started only at _deploy. But _export also created build-conf, so if we failed there and rolled back, we'd leave behind build-conf. The complexity is a result of starting the transaction at _export. Parts of 'prepare' need to happen only at _deploy. -- To view, visit http://gerrit.ovirt.org/27167 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2507ea0c6ecd6d0a69f56d0693fcafd21f58992f Gerrit-PatchSet: 9 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
