Moti Asayag has posted comments on this change.
Change subject: core: nic validations on running VM
......................................................................
Patch Set 1: (10 inline comments)
I think unit-tests will be welcomed here as the can-do-action is a testable
code.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
Line 991: .getNetworkDAO()
please refactor DAO call into AuditLogable base:
DbFacade.getInstance().getNetworkDAO() --> getNetworkDao() - it will ease
testing.
Line 1027:
getReturnValue().getCanDoActionMessages().add(String.format("$networks %1$s",
repalce getReturnValue().getCanDoActionMessages().add() with
addCanDoActionMessage()
Line 1047:
getReturnValue().getCanDoActionMessages().add(String.format("$networks %1$s",
same
....................................................
File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
Line 687: ACTION_TYPE_FAILED_INTERFACE_NETWORK_NOT_CONFIGURED=Failed ${action}
${type}. One on more network interfaces have incomplete network configuration.
Please configure these interfaces and try again.
s/on/or
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NetworkUtils.java
Line 108:
This should be generalized to
org.ovirt.engine.core.common.businessentities.Entities and the return type
should be Set<String> as a name repetition is redundant.
Line 138:
this also could be generalized as substruct method, for example:
List<String> substruct(Collection<E extends Nameable> a, Set<E extends
Nameable> b){
...
}
but it requires changing the way this method is called.
....................................................
File
frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
Line 1830: @DefaultStringValue("Failed ${action} ${type}. One on more
network interfaces have incomplete network configuration. Please configure
these interfaces and try again.")
s/on/or
....................................................
File
frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
Line 689: ACTION_TYPE_FAILED_INTERFACE_NETWORK_NOT_CONFIGURED=Failed ${action}
${type}. One on more network interfaces have incomplete network configuration.
Please configure these interfaces and try again.
s/on/or
....................................................
File
frontend/webadmin/modules/userportal/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
Line 661: ACTION_TYPE_FAILED_INTERFACE_NETWORK_NOT_CONFIGURED=Failed ${action}
${type}. One on more network interfaces have incomplete network configuration.
Please configure these interfaces and try again.
s/on/or
....................................................
File
frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
Line 689: ACTION_TYPE_FAILED_INTERFACE_NETWORK_NOT_CONFIGURED=Failed ${action}
${type}. One on more network interfaces have incomplete network configuration.
Please configure these interfaces and try again.
s/on/or
--
To view, visit http://gerrit.ovirt.org/5054
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b7d9b5f879b17f384d8a2b540fa6f6b55bf8f46
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
