Moti Asayag has posted comments on this change.
Change subject: core: nic validations on running VM
......................................................................
Patch Set 2: Looks good to me, but someone else must approve
(2 inline comments)
minor comments inside - beside looks fine to me.
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Entities.java
Line 59: if (entityList != null) {
minor comment - you can check also the size/content, eg:
if (entityList != null && !entityList.isEmpty()){...
}
....................................................
File
backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/businessentities/EntitiesTest.java
Line 58: Assert.assertTrue(!names.contains("network3"));
please replace with assertFalse and negate the condition
--
To view, visit http://gerrit.ovirt.org/5054
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b7d9b5f879b17f384d8a2b540fa6f6b55bf8f46
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
