Simone Tiraboschi has posted comments on this change. Change subject: WebSocketProxy on a separate host ......................................................................
Patch Set 10: (6 comments) http://gerrit.ovirt.org/#/c/26898/10/packaging/setup/plugins/ovirt-engine-setup/base/core/misc.py File packaging/setup/plugins/ovirt-engine-setup/base/core/misc.py: Line 67: # TODO: ask if user is really going to install the engine as Line 68: # Didi proposed Line 69: self.environment[ Line 70: osetupcons.CoreEnv.ENGINE_LOCAL Line 71: ] = True > You should probably setdefault to None in common during stage_boot or somet Done Line 72: Line 73: http://gerrit.ovirt.org/#/c/26898/10/packaging/setup/plugins/ovirt-engine-setup/websocket_proxy/config.py File packaging/setup/plugins/ovirt-engine-setup/websocket_proxy/config.py: Line 17 Line 18 Line 19 Line 20 Line 21 > we usually keep two blank lines here Done Line 21 Line 22 Line 23 Line 24 Line 25 > same Done Line 70 Line 71 Line 72 Line 73 Line 74 > Please address this - adapt code if needed and edit the comment. Done Line 67: self.environment[ Line 68: osetupcons.CoreEnv.ENGINE_LOCAL Line 69: ] is not None and self.environment[ Line 70: osetupcons.CoreEnv.ENGINE_LOCAL Line 71: ] > Not sure what you check here, perhaps you meant: Done Line 72: ): Line 73: self._local_engine = True Line 74: else: Line 75: self._local_engine = False Line 409: 'the engine host' Line 410: ) Line 411: ) Line 412: self._fetch_certs() Line 413: # FIX: I've to ensure also that proxy cert it's relative to my host > So scp is mandatory? I think we should at least let the user copy them manu II want firstly be sure that everything is working in the automatic way, then I'll add also that options Line 414: Line 415: if self._local_wsp: Line 416: self.environment[otopicons.CoreEnv.MAIN_TRANSACTION].append( Line 417: filetransaction.FileTransaction( -- To view, visit http://gerrit.ovirt.org/26898 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I169604429e5a2d72573b05c0e5481306edfdd935 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Lev Veyde <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
