Yedidyah Bar David has posted comments on this change. Change subject: WebSocketProxy on a separate host ......................................................................
Patch Set 11: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/26898/11/packaging/setup/plugins/ovirt-engine-setup/websocket_proxy/config.py File packaging/setup/plugins/ovirt-engine-setup/websocket_proxy/config.py: Line 66: osetupcons.Defaults.DEFAULT_WEBSOCKET_PROXY_PORT Line 67: ) Line 68: self._local_engine = self.environment.get( Line 69: osetupcons.CoreEnv.ENGINE_LOCAL, False Line 70: ) You did setdefault, why not just var=env[key]? Anyway, if you want it this way, please indent like: self._local_engine = self.environment.get( osetupcons.CoreEnv.ENGINE_LOCAL, False ) Line 71: Line 72: @plugin.event( Line 73: stage=plugin.Stages.STAGE_LATE_SETUP, Line 74: ) -- To view, visit http://gerrit.ovirt.org/26898 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I169604429e5a2d72573b05c0e5481306edfdd935 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Lev Veyde <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
