Greg Padgett has uploaded a new change for review. Change subject: [WIP] core: fix log messages in AsyncTaskBase ......................................................................
[WIP] core: fix log messages in AsyncTaskBase Change-Id: Id625b80bbe1d5968250136e8184a4250c5f63155 Bug-Url: https://bugzilla.redhat.com/?????? Signed-off-by: Greg Padgett <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/AsyncTaskBase.java 1 file changed, 7 insertions(+), 7 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/83/27283/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/AsyncTaskBase.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/AsyncTaskBase.java index 2aba688..2acfb15 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/AsyncTaskBase.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/AsyncTaskBase.java @@ -123,7 +123,7 @@ if (state != AsyncTaskState.AttemptingEndAction && state != AsyncTaskState.Cleared && state != AsyncTaskState.ClearFailed) { - log.infoFormat("BaseAsyncTask::startPollingTask: Starting to poll task '{0}'.", getVdsmTaskId()); + log.infoFormat("AsyncTaskBase::startPollingTask: Starting to poll task '{0}'.", getVdsmTaskId()); concreteStartPollingTask(); } } @@ -194,7 +194,7 @@ catch (RuntimeException e) { log.error( String.format( - "BaseAsyncTask::PollAndUpdateTask: Handling task '%1$s' (State: %2$s, Parent Command: %3$s, Parameters Type: %4$s) threw an exception", + "AsyncTaskBase::PollAndUpdateTask: Handling task '%1$s' (State: %2$s, Parent Command: %3$s, Parameters Type: %4$s) threw an exception", getVdsmTaskId(), getState(), (getParameters().getDbAsyncTask() @@ -244,13 +244,13 @@ protected void RemoveTaskFromDB() { try { if (coco.removeByVdsmTaskId(getVdsmTaskId()) != 0) { - log.infoFormat("BaseAsyncTask::RemoveTaskFromDB: Removed task {0} from DataBase", getVdsmTaskId()); + log.infoFormat("AsyncTaskBase::RemoveTaskFromDB: Removed task {0} from DataBase", getVdsmTaskId()); } } catch (RuntimeException e) { log.error(String.format( - "BaseAsyncTask::RemoveTaskFromDB: Removing task %1$s from DataBase threw an exception.", + "AsyncTaskBase::RemoveTaskFromDB: Removing task %1$s from DataBase threw an exception.", getVdsmTaskId()), e); } } @@ -274,7 +274,7 @@ protected void LogEndTaskSuccess() { log.infoFormat( - "BaseAsyncTask::OnTaskEndSuccess: Task '{0}' (Parent Command {1}, Parameters Type {2}) ended successfully.", + "AsyncTaskBase::OnTaskEndSuccess: Task '{0}' (Parent Command {1}, Parameters Type {2}) ended successfully.", getVdsmTaskId(), (getParameters().getDbAsyncTask().getaction_type()), getParameters() @@ -288,7 +288,7 @@ protected void LogEndTaskFailure() { log.errorFormat( - "BaseAsyncTask::LogEndTaskFailure: Task '{0}' (Parent Command {1}, Parameters Type {2}) ended with failure:" + "AsyncTaskBase::LogEndTaskFailure: Task '{0}' (Parent Command {1}, Parameters Type {2}) ended with failure:" + "\r\n" + "-- Result: '{3}'" + "\r\n" + "-- Message: '{4}'," + "\r\n" + "-- Exception: '{5}'", getVdsmTaskId(), (getParameters().getDbAsyncTask().getaction_type()), @@ -307,7 +307,7 @@ protected void LogTaskDoesntExist() { log.errorFormat( - "BaseAsyncTask::LogTaskDoesntExist: Task '{0}' (Parent Command {1}, Parameters Type {2}) does not exist.", + "AsyncTaskBase::LogTaskDoesntExist: Task '{0}' (Parent Command {1}, Parameters Type {2}) does not exist.", getVdsmTaskId(), (getParameters().getDbAsyncTask().getaction_type()), getParameters() -- To view, visit http://gerrit.ovirt.org/27283 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id625b80bbe1d5968250136e8184a4250c5f63155 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
