Greg Padgett has posted comments on this change. Change subject: [WIP] core: fix log messages in AsyncTaskBase ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/27283/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/AsyncTaskBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/AsyncTaskBase.java: Line 193: Line 194: catch (RuntimeException e) { Line 195: log.error( Line 196: String.format( Line 197: "AsyncTaskBase::PollAndUpdateTask: Handling task '%1$s' (State: %2$s, Parent Command: %3$s, Parameters Type: %4$s) threw an exception", > I'll be glad if we can remove the prefix of the class name, as we can see - Agreed, and redundant in the log file. Going further, many of the method name prefixes in this file are wrong and/or don't add any value, for example: "LogTaskCleanFailure: Clearing task '{0}' failed." I propose we ditch the prefixes and fix up the messages as needed so they can stand on their own. Thoughts? Line 198: getVdsmTaskId(), Line 199: getState(), Line 200: (getParameters().getDbAsyncTask() Line 201: .getaction_type()), -- To view, visit http://gerrit.ovirt.org/27283 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id625b80bbe1d5968250136e8184a4250c5f63155 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Greg Padgett <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
