Ravi Nori has posted comments on this change. Change subject: [WIP] core, db, packaging: introduce EntityTaskStrategy ......................................................................
Patch Set 2: (3 comments) http://gerrit.ovirt.org/#/c/26913/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/AsyncTaskManager.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/AsyncTaskManager.java: Line 458: private void updateTaskStatuses( Line 459: Map<Guid, Map<Guid, AsyncTaskStatus>> poolsAllTasksMap) { Line 460: for (AsyncTask task : _tasks.values()) { Line 461: if (task.getShouldPoll()) { Line 462: if (task.isSpmTask()) { > hmm, what if you move the code for spm task to the strategy, and introduce +1 Line 463: Map<Guid, AsyncTaskStatus> asyncTasksForPoolMap = poolsAllTasksMap Line 464: .get(task.getObjectId()); Line 465: Line 466: // If the storage pool id exists Line 525: Set<Guid> poolsOfActiveTasks = new HashSet<Guid>(); Line 526: Line 527: for (AsyncTask task : _tasks.values()) { Line 528: if (task.isSpmTask() && task.getShouldPoll()) { Line 529: poolsOfActiveTasks.add(task.getObjectId()); > not sure if i would call it "objectId" - it's too vague. +1 Line 530: } Line 531: } Line 532: return poolsOfActiveTasks; Line 533: } http://gerrit.ovirt.org/#/c/26913/2/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/upgrade/asynctasks.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/upgrade/asynctasks.py: Line 155: need I don't think we should handle upgrade issues in these patches -- To view, visit http://gerrit.ovirt.org/26913 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I59392247ff2caf997030f4cf975273b3bac69c33 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Greg Padgett <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
