Yair Zaslavsky has posted comments on this change. Change subject: [WIP] core, db, packaging: introduce EntityTaskStrategy ......................................................................
Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/26913/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/EntityTaskStrategy.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/EntityTaskStrategy.java: Line 14: Line 15: /** Line 16: * Strategy for async tasks whose status is ascertained via callbacks to the issuing command. Line 17: */ Line 18: public class EntityTaskStrategy implements AsyncTaskStrategy { > The task is tied to an entity--in the Live Merge case, a VM. Another optio Usually I'm not picky about names either, in the past we did have EntityTasks, but we got rid of them in favor of command coordination, and I would not like to get back to this situation. So, the "task container" in case of live merge is a VM? Not HSM ? Line 19: private final AsyncTask task; Line 20: private CommandCallback command; Line 21: private static final Log log = LogFactory.getLog(EntityTaskStrategy.class); Line 22: http://gerrit.ovirt.org/#/c/26913/2/packaging/dbscripts/upgrade/03_05_0320_alter_async_tasks_for_non_spm_tasks.sql File packaging/dbscripts/upgrade/03_05_0320_alter_async_tasks_for_non_spm_tasks.sql: Line 2: select fn_db_rename_column('async_tasks', 'storage_pool_id', 'object_id'); Line 3: select fn_db_add_column('async_tasks', 'object_type', 'INTEGER'); Line 4: Line 5: -- existing values correspond to VdcObjectType.StoragePool (14) Line 6: UPDATE async_tasks SET object_type = 14 WHERE object_type IS NULL AND object_id IS NOT NULL; just don't forget to change object_id and object_type here to something else as we discussed. -- To view, visit http://gerrit.ovirt.org/26913 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I59392247ff2caf997030f4cf975273b3bac69c33 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Greg Padgett <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
