Vojtech Szocs has posted comments on this change. Change subject: userportal, webadmin: new look and feel based on PatternFly ......................................................................
Patch Set 40: (1 comment) Greg, thanks for addressing my comments. http://gerrit.ovirt.org/#/c/24594/40/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/GwtCommon.gwt.xml File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/GwtCommon.gwt.xml: Line 32: <generate-with class="org.ovirt.engine.ui.common.binding.ElementIdHandlerGenerator"> Line 33: <when-type-assignable class="org.ovirt.engine.ui.common.idhandler.ElementIdHandler" /> Line 34: </generate-with> Line 35: Line 36: <set-configuration-property name="CssResource.style" value="pretty" /> > removed. just here for development purposes (so I can hunt down classes) > just here for development purposes (so I can hunt down classes) Hm, if this helped you during development, I'd say we should make "CssResource.style" configurable via Maven property, along with updating GWT debug wiki [1] on how to make CSS class names pretty. [1] http://www.ovirt.org/DebugFrontend (I can imagine this can be helpful for future development as well.) Line 37: -- To view, visit http://gerrit.ovirt.org/24594 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I806f2d163d80edb632c4e87524c327066cf3377a Gerrit-PatchSet: 40 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
