Greg Sheremeta has posted comments on this change. Change subject: userportal, webadmin: new look and feel based on PatternFly ......................................................................
Patch Set 40: (3 comments) http://gerrit.ovirt.org/#/c/24594/40/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/GwtCommon.gwt.xml File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/GwtCommon.gwt.xml: Line 32: <generate-with class="org.ovirt.engine.ui.common.binding.ElementIdHandlerGenerator"> Line 33: <when-type-assignable class="org.ovirt.engine.ui.common.idhandler.ElementIdHandler" /> Line 34: </generate-with> Line 35: Line 36: <set-configuration-property name="CssResource.style" value="pretty" /> > > just here for development purposes (so I can hunt down classes) Great idea, and I will do this in a separate patch. Line 37: http://gerrit.ovirt.org/#/c/24594/40/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AbstractUiCommandButton.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AbstractUiCommandButton.java: Line 100: setLabel(command.getTitle()); Line 101: } Line 102: } Line 103: Line 104: protected abstract Widget getButtonWidget(); > I see that you've changed return type to be generic Widget, but this way we I attempted this, but the common denominator here needs to be a subclass of both gwtbootstrap3's Button and GWT's ButtonBase. So using interfaces won't work. Must use Widget. Line 105: http://gerrit.ovirt.org/#/c/24594/40/frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/tab/UserPortalMainTab.java File frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/tab/UserPortalMainTab.java: Line 9: import com.google.gwt.user.client.ui.HTMLPanel; Line 10: import com.google.gwt.user.client.ui.Widget; Line 11: import com.gwtplatform.mvp.client.TabData; Line 12: Line 13: public class UserPortalMainTab implements TabDefinition { > Hm, I assume that implementing TabDefinition interface directly here is bec Done Line 14: Line 15: private float priority; Line 16: private boolean accessible; Line 17: private AbstractTabPanel tabPanel; -- To view, visit http://gerrit.ovirt.org/24594 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I806f2d163d80edb632c4e87524c327066cf3377a Gerrit-PatchSet: 40 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
