Yair Zaslavsky has posted comments on this change. Change subject: core : Allow redirection of all logs to syslog using extension ......................................................................
Patch Set 2: (3 comments) http://gerrit.ovirt.org/#/c/27431/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java: Line 193: } Line 194: } Line 195: } Line 196: Line 197: private void createInternalSysLogConfigurations() { Following Alon's comment - please remove this from the patch - if syslog is provided as external plugin, then we should not add code to this bean. The reason the code exists here , is that we must read data from vdc options, and according to it initialize the configuration. Line 198: Properties syslogConfig = new Properties(); Line 199: syslogConfig.put(Base.ConfigKeys.NAME, "builtin-syslog-logger"); Line 200: syslogConfig.put(Base.ConfigKeys.PROVIDES, org.ovirt.engine.api.extensions.logger.Logger.class.getName()); Line 201: syslogConfig.put(Base.ConfigKeys.ENABLED, "true"); http://gerrit.ovirt.org/#/c/27431/2/backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/logger/Logger.java File backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/logger/Logger.java: Line 4: import org.ovirt.engine.api.extensions.ExtUUID; Line 5: Line 6: import java.util.logging.LogRecord; Line 7: Line 8: public class Logger { I would like to see the logger plugin more general, and have no syslog related info in the API, all should be configurable. Line 9: /** Line 10: * Invoke keys. Line 11: */ Line 12: public static class InvokeKeys { http://gerrit.ovirt.org/#/c/27431/2/backend/manager/modules/logger/src/main/java/org/ovirt/engine/core/logger/LoggerHandler.java File backend/manager/modules/logger/src/main/java/org/ovirt/engine/core/logger/LoggerHandler.java: Line 12: Line 13: public class LoggerHandler extends Handler { Line 14: Line 15: private ExtensionProxy extension; Line 16: private String loggerExtensionName = "builtin-syslog-logger"; Following my suggestion - IMHO this should not be syslog, but a general logger. Line 17: Line 18: public LoggerHandler() {} Line 19: Line 20: @Override -- To view, visit http://gerrit.ovirt.org/27431 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia0dae8ffe53c3489af06d6684c72e6b431002404 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
